Skip to content

Log TensorBoard histograms #19851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Log TensorBoard histograms #19851

wants to merge 11 commits into from

Conversation

dominicgkerr
Copy link
Contributor

@dominicgkerr dominicgkerr commented May 6, 2024 •
edited
Loading

What does this PR do?

Allows LightningModule to log Tensorboard histograms

Fixes #19743

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19851.org.readthedocs.build/en/19851/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels May 6, 2024
@dominicgkerr dominicgkerr mentioned this pull request May 6, 2024
Open
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (6989e15) to head (c36bf45).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19851   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23688    23690    +2     
=======================================
+ Hits        20666    20668    +2     
  Misses       3022     3022

@stale Stale
Copy link

stale bot commented Apr 26, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 26, 2025
@stale stale bot removed won't fix This will not be worked on labels Aug 19, 2025
Borda
Borda previously approved these changes Aug 19, 2025
View reviewed changes
SkafteNicki
SkafteNicki requested changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should touch essentially the core logic of self.log to support one feature for one logger. Could we please instead have a specialized function for the tensorboard logger called log_hist similar to the specialized methods we have in other loggers:
https://lightning.ai/docs/pytorch/stable/api/lightning.pytorch.loggers.tensorboard.html#module-lightning.pytorch.loggers.tensorboard

cc: @Borda

@Borda
Copy link
Contributor

Borda commented Aug 21, 2025

I do not think we should touch essentially the core logic of self.log to support one feature for one logger.

good call :)

@Borda Borda self-requested a review August 21, 2025 08:05
@Borda Borda added the waiting on author Waiting on user action, correction, or update label Sep 2, 2025
@SkafteNicki SkafteNicki added logger Related to the Loggers logger: tensorboard labels Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki requested changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
fabric lightning.fabric.Fabric logger: tensorboard logger Related to the Loggers pl Generic label for PyTorch Lightning package waiting on author Waiting on user action, correction, or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log TensorBoard histograms
3 participants
@dominicgkerr @Borda @SkafteNicki